chrome/browser/resources/sync_internals/sync_index.html - Issue 8479042: UI polish for certificate viewer

Side by Side Diff: chrome/browser/resources/sync_internals/sync_index.html

Issue 8479042: UI polish for certificate viewer (Closed) Base URL: /usr/local/google/home/bshe/NoTouchChromium/../TouchChromium/src/@trunk

Patch Set: Remove body margins of two internal pages(due to the changes in tabs.css file). Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html i18n-values="dir:textdirection;">	2 <html i18n-values="dir:textdirection;">

3 <head>	3 <head>

4 <!-- If you change the title, make sure you also update	4 <!-- If you change the title, make sure you also update

5 chrome/test/functional/special_tabs.py. -->	5 chrome/test/functional/special_tabs.py. -->

6 <title>Sync Internals</title>	6 <title>Sync Internals</title>

7 <link rel="stylesheet" href="chrome://resources/css/list.css">	7 <link rel="stylesheet" href="chrome://resources/css/list.css">

8 <link rel="stylesheet" href="chrome://resources/css/tabs.css">	8 <link rel="stylesheet" href="chrome://resources/css/tabs.css">

9 <link rel="stylesheet" href="chrome://resources/css/tree.css">	9 <link rel="stylesheet" href="chrome://resources/css/tree.css">

10 <link rel="stylesheet" href="sync_search.css">	10 <link rel="stylesheet" href="sync_search.css">

11 <link rel="stylesheet" href="sync_node_browser.css">	11 <link rel="stylesheet" href="sync_node_browser.css">

	12 <style>

	13 body {

	14 /* Remove body margin as the general tabpanels do not have outer border. */

	15 margin: 0;

	16 }
	flackr 2011/11/21 20:43:31 Move to CSS file. Move to CSS file. bshe 2011/11/22 16:26:24 Should I create a new CSS file for this rule? Or s Show quoted text On 2011/11/21 20:43:31, flackr wrote: > Move to CSS file. Should I create a new CSS file for this rule? Or should I put this rule to sync_search.css/sync_node_browser.css file? sync_search.css and sync_node_browser.css dont seem like the right place to put this rule. They are for search and node_browser tabs only. Also not sure create a new css file with just one rule is good or bad? flackr 2011/11/22 17:02:59 It's okay to create a new file with one rule, if t Show quoted text On 2011/11/22 16:26:24, bshe wrote: > On 2011/11/21 20:43:31, flackr wrote: > > Move to CSS file. > Should I create a new CSS file for this rule? Or should I put this rule to > sync_search.css/sync_node_browser.css file? sync_search.css and > sync_node_browser.css dont seem like the right place to put this rule. They are > for search and node_browser tabs only. Also not sure create a new css file with > just one rule is good or bad? It's okay to create a new file with one rule, if there are more overall rules for the page then it can be further used. As you say, both the existing css files are specific to one tab, so adding a general file for the overall page makes sense :-) bshe 2011/11/22 19:20:46 Done. Show quoted text On 2011/11/22 17:02:59, flackr wrote: > On 2011/11/22 16:26:24, bshe wrote: > > On 2011/11/21 20:43:31, flackr wrote: > > > Move to CSS file. > > Should I create a new CSS file for this rule? Or should I put this rule to > > sync_search.css/sync_node_browser.css file? sync_search.css and > > sync_node_browser.css dont seem like the right place to put this rule. They > are > > for search and node_browser tabs only. Also not sure create a new css file > with > > just one rule is good or bad? > > It's okay to create a new file with one rule, if there are more overall rules > for the page then it can be further used. As you say, both the existing css > files are specific to one tab, so adding a general file for the overall page > makes sense :-) Done.
	17 </style>

12	18

13 <script src="chrome://resources/css/tree.css.js"></script>	19 <script src="chrome://resources/css/tree.css.js"></script>

14	20

15 <script src="chrome://resources/js/cr.js"></script>	21 <script src="chrome://resources/js/cr.js"></script>

16 <script src="chrome://resources/js/cr/event_target.js"></script>	22 <script src="chrome://resources/js/cr/event_target.js"></script>

17 <script src="chrome://resources/js/cr/ui.js"></script>	23 <script src="chrome://resources/js/cr/ui.js"></script>

18 <script src="chrome://resources/js/cr/ui/focus_outline_manager.js"></script>	24 <script src="chrome://resources/js/cr/ui/focus_outline_manager.js"></script>

19 <script src="chrome://resources/js/cr/ui/splitter.js"></script>	25 <script src="chrome://resources/js/cr/ui/splitter.js"></script>

20	26

21 <!-- List stuff. -->	27 <!-- List stuff. -->

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 </tabpanel>	79 </tabpanel>

74 </tabpanels>	80 </tabpanels>

75 </tabbox>	81 </tabbox>

76	82

77 <script src="chrome://resources/js/i18n_template.js"></script>	83 <script src="chrome://resources/js/i18n_template.js"></script>

78 <script src="chrome://resources/js/i18n_process.js"></script>	84 <script src="chrome://resources/js/i18n_process.js"></script>

79 <script src="chrome://resources/js/jstemplate_compiled.js"></script>	85 <script src="chrome://resources/js/jstemplate_compiled.js"></script>

80 <script src="chrome://sync-internals/sync_index.js"></script>	86 <script src="chrome://sync-internals/sync_index.js"></script>

81 </body>	87 </body>

82 </html>	88 </html>

OLD	NEW

« chrome/browser/resources/shared/css/tabs.css ('K') | « chrome/browser/resources/shared/css/tabs.css ('k') | chrome/browser/ui/browser.h » ('j') | chrome/browser/ui/dialog_style.h » ('J')