compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java - Issue 8479037: Provide enclosing element (method) for local function object, issue 145

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

Issue 8479037: Provide enclosing element (method) for local function object, issue 145 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/backend/js/Normalizer.java » ('j') | compiler/java/com/google/dart/compiler/resolver/Element.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

diff --git a/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java b/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

index 79fadd59d835ddd8afc9b328264b1f175de57f04..47f89893d824afce869c30d860de71fabb36b3ce 100644

--- a/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

+++ b/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

@@ -2478,7 +2478,9 @@ public class GenerateJavascriptAST {

mangledName = null;

qualifier = (JsExpression) generate(target);

EnclosingElement enclosingElement = element.getEnclosingElement();

- if ((kind == ElementKind.FUNCTION_OBJECT) && (element.getEnclosingElement() != null)) {

+ if (kind == ElementKind.FUNCTION_OBJECT

zundel 2011/11/07 19:26:53 nit. I would just move this into a separate FUNCT

+ && enclosingElement != null

+ && enclosingElement.getKind() == ElementKind.CLASS) {

// Function-object invocations can be made directly, unless they're closures (in which

// case their enclosing-element will be null).

method = (MethodElement) element;