Issue 8479028: MIPS: Fixed a bug in StringHelper::GenerateTwoCharacterSymbolTableProbe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8479028: MIPS: Fixed a bug in StringHelper::GenerateTwoCharacterSymbolTableProbe. (Closed)

Created:
9 years, 1 month ago by kisg

Modified:
9 years, 1 month ago

Reviewers:
Paul Lind, danno, Michael Starzinger, Yang

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Fixed a bug in StringHelper::GenerateTwoCharacterSymbolTableProbe. r9871 (5baeaf57) changed the fill value for deleted entries in hash tables from null_value to the_hole_value. This commit changes an assertion in MIPS code that expects this value. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9955

Patch Set 1 #

Patch Set 2 : Rebased on r9917, fixed comments #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/mips/code-stubs-mips.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kisg

The following comment in issue 1808 describes the situation in more detail, other architectures seem ...

9 years, 1 month ago (2011-11-07 08:34:03 UTC) #1

Yang

9 years, 1 month ago (2011-11-10 14:13:29 UTC) #2

On 2011/11/07 08:34:03, kisg wrote:
> The following comment in issue 1808 describes the situation in more detail,
> other architectures seem to be affected as well:
> http://code.google.com/p/v8/issues/detail?id=1808#c3

LGTM and landing.

Expand Messages | Collapse Messages