Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8479027: Make third-party cookie blocking strict by default (Closed)

Created:
9 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
9 years, 1 month ago
Reviewers:
Mike West
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Make third-party cookie blocking strict by default BUG=98241 TEST=CookieSettings.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108846

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -46 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/content_settings/cookie_settings.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/content_settings/cookie_settings_unittest.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
plz review
9 years, 1 month ago (2011-11-07 08:00:22 UTC) #1
Mike West
On 2011/11/07 08:00:22, jochen wrote: > plz review One tiny nit, and one question: why ...
9 years, 1 month ago (2011-11-07 08:26:27 UTC) #2
jochen (gone - plz use gerrit)
On 2011/11/07 08:26:27, Mike West (chromium) wrote: > On 2011/11/07 08:00:22, jochen wrote: > > ...
9 years, 1 month ago (2011-11-07 08:27:54 UTC) #3
Mike West
On 2011/11/07 08:27:54, jochen wrote: > So we can easily roll back the functionality in ...
9 years, 1 month ago (2011-11-07 08:30:47 UTC) #4
Mike West
*ahem* http://codereview.chromium.org/8479027/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/8479027/diff/1/chrome/common/chrome_switches.cc#newcode837 chrome/common/chrome_switches.cc:837: // When the option to block third-party cookies, ...
9 years, 1 month ago (2011-11-07 08:32:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8479027/2002
9 years, 1 month ago (2011-11-07 08:35:28 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-07 09:37:49 UTC) #7
Change committed as 108846

Powered by Google App Engine
This is Rietveld 408576698