Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 8479026: Make it so that turning off sync for extensions in the preferences UI also (Closed)

Created:
9 years, 1 month ago by not at google - send to devlin
Modified:
9 years, 1 month ago
CC:
chromium-reviews, akalin
Visibility:
Public.

Description

Make it so that turning off sync for extensions in the preferences UI also turns off sync for extension settings, ditto for apps and app settings. BUG=98488 TEST=Manually by bringing up two browser instances and enabling/disabling extension/app sync in preferences. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109779

Patch Set 1 #

Patch Set 2 : sync (nontrivial merge) #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 6 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
Hi Tim, sending this code review to you because Fred is on sick leave.
9 years, 1 month ago (2011-11-07 02:53:12 UTC) #1
not at google - send to devlin
Ping?
9 years, 1 month ago (2011-11-10 22:20:01 UTC) #2
tim (not reviewing)
lgtm
9 years, 1 month ago (2011-11-11 23:50:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/8479026/8001
9 years, 1 month ago (2011-11-12 05:01:32 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-12 07:14:50 UTC) #5
Change committed as 109779

Powered by Google App Engine
This is Rietveld 408576698