Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 8479006: Fix pc descriptor emission for skipped unary oepration +. Eliminates last co19 crash. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 1219)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -1177,7 +1177,6 @@
return;
}
node->operand()->Visit(this);
- MarkDeoptPoint(node->id(), node->token_index());
if (node->kind() == Token::kADD) {
// Unary operator '+' does not exist, it's a NOP, skip it.
if (!IsResultNeeded(node)) {
@@ -1185,6 +1184,7 @@
}
return;
}
+ MarkDeoptPoint(node->id(), node->token_index());
String& operator_name = String::ZoneHandle();
if (node->kind() == Token::kSUB) {
operator_name = String::NewSymbol(Token::Str(Token::kNEGATE));
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698