Issue 8478030: Add support for audio capture devices. Previously only output was supported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8478030: Add support for audio capture devices. Previously only output was supported. (Closed)

Created:
9 years, 1 month ago by tommi (sloooow) - chröme

Modified:
9 years, 1 month ago

Reviewers:
henrika (OOO until Aug 14)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add support for audio capture devices. Previously only output was supported. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109617

Patch Set 2 : Fix includes as pointed out by henrika #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -2 lines)			Patch
	M	content/test/webrtc_audio_device_test.h	View	1	3 chunks	+10 lines, -1 line	0 comments	Download
	M	content/test/webrtc_audio_device_test.cc	View	1	7 chunks	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

henrika (OOO until Aug 14)

LGTM w/ nit. http://codereview.chromium.org/8478030/diff/1/content/test/webrtc_audio_device_test.h File content/test/webrtc_audio_device_test.h (right): http://codereview.chromium.org/8478030/diff/1/content/test/webrtc_audio_device_test.h#newcode176 content/test/webrtc_audio_device_test.h:176: scoped_ptr<media_stream::MediaStreamManager> media_stream_manager_; Why needed now when ...

9 years, 1 month ago (2011-11-11 11:05:41 UTC) #2

tommi (sloooow) - chröme

9 years, 1 month ago (2011-11-11 11:09:10 UTC) #3

On 2011/11/11 11:05:41, henrika1 wrote:
> LGTM w/ nit.
> 
>
http://codereview.chromium.org/8478030/diff/1/content/test/webrtc_audio_devic...
> File content/test/webrtc_audio_device_test.h (right):
> 
>
http://codereview.chromium.org/8478030/diff/1/content/test/webrtc_audio_devic...
> content/test/webrtc_audio_device_test.h:176:
> scoped_ptr<media_stream::MediaStreamManager> media_stream_manager_;
> Why needed now when adding input?

AudioInputRendererHost::OnStartDevice requires a media_stream_manager() from the
resource context. The media stream manager is the owner of the
AudioInputDeviceManager.  AudioInputRendererHost uses this to start the device. 
Subsequently OnDeviceStarted is triggered.

Expand Messages | Collapse Messages

Issue 8478030: Add support for audio capture devices. Previously only output was supported. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix includes as pointed out by henrika #

Messages