Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: tests/isolate/src/PromiseBasedTest.dart

Issue 8478014: convert isolate TestFramework from Promise Future (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: change TestFramework to Future Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/isolate/src/PromiseBasedTest.dart
diff --git a/tests/isolate/src/PromiseBasedTest.dart b/tests/isolate/src/PromiseBasedTest.dart
index 38068eb6ed97a3d3985c23cbac172ee78e95746e..2be2d7b2a5a97ae981a5c5b4a01ef1ef58f9f1d9 100644
--- a/tests/isolate/src/PromiseBasedTest.dart
+++ b/tests/isolate/src/PromiseBasedTest.dart
@@ -33,12 +33,13 @@ void test(TestExpectation expect) {
Proxy proxy = new Proxy.forIsolate(new TestIsolate());
proxy.send([42]); // Seed the isolate.
Promise<int> result = new PromiseProxy<int>(proxy.call([87]));
- Promise promise = expect.completes(result).then((int value) {
+ Completer completer = new Completer();
+ expect.completes(result).then((int value) {
//print("expect 1: $value");
Expect.equals(42 + 87, value);
- return 99;
+ completer.complete(99);
});
- expect.completes(promise).then((int value) {
+ expect.completes(completer.future).then((int value) {
//print("expect 2: $value");
Expect.equals(99, value);
expect.succeeded();
@@ -50,21 +51,22 @@ void expandedTest(TestExpectation expect) {
proxy.send([42]); // Seed the isolate.
Promise<SendPort> sendCompleter = proxy.call([87]);
Promise<int> result = new Promise<int>();
- ReceivePort completer = new ReceivePort.singleShot();
- completer.receive((var msg, SendPort _) {
+ ReceivePort receivePort = new ReceivePort.singleShot();
+ receivePort.receive((var msg, SendPort _) {
//print("test completer");
result.complete(msg[0]);
});
sendCompleter.addCompleteHandler((SendPort port) {
//print("test send");
- port.send([completer.toSendPort()], null);
+ port.send([receivePort.toSendPort()], null);
});
- Promise promise = expect.completes(result).then((int value) {
+ Completer completer = new Completer();
+ expect.completes(result).then((int value) {
//print("expect 1: $value");
Expect.equals(42 + 87, value);
- return 99;
+ completer.complete(99);
});
- expect.completes(promise).then((int value) {
+ expect.completes(completer.future).then((int value) {
//print("expect 2: $value");
Expect.equals(99, value);
expect.succeeded();

Powered by Google App Engine
This is Rietveld 408576698