Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 8477045: Add Elf 32 Support to Courgette. (Closed)

Created:
9 years, 1 month ago by dgarrett
Modified:
9 years, 1 month ago
Reviewers:
csilv, dgarrett, sra1
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add Elf 32 Support to Courgette. This change takes advantage of recent refactoring and adds support for Elf X86 32 executables to courgette. It should have no effect on handling of Windows PE executables. We have planned ahead to be able to restrict the code size of the courgette library in different cases to reduce patcher sizes, but this change does not yet take advantage of that (all platforms are supported everywhere). Also, the patcher class currently contains a very small amount of Elf/PE specific code for recreating relocation tables that cannot (currently) be compiled out. BUG=chromium-os:22149 TEST=Please verify that Chrome/Chromium patches can still be generated and work. Also, please see how much the updater executable which is downloaded to users has changed in size since R16. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109089

Patch Set 1 #

Patch Set 2 : Remove debug printf present by mistake. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1109 lines, -51 lines) Patch
M courgette/assembly_program.h View 1 chunk +4 lines, -1 line 0 comments Download
M courgette/assembly_program.cc View 4 chunks +24 lines, -8 lines 0 comments Download
M courgette/bsdiff_memory_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M courgette/courgette.h View 1 chunk +1 line, -0 lines 0 comments Download
M courgette/courgette.gyp View 3 chunks +5 lines, -0 lines 0 comments Download
M courgette/disassembler.h View 1 chunk +1 line, -1 line 0 comments Download
M courgette/disassembler.cc View 2 chunks +8 lines, -1 line 0 comments Download
A courgette/disassembler_elf_32_x86.h View 1 chunk +143 lines, -0 lines 0 comments Download
A courgette/disassembler_elf_32_x86.cc View 1 chunk +602 lines, -0 lines 0 comments Download
A courgette/disassembler_elf_32_x86_unittest.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M courgette/disassembler_win32_x86.cc View 1 chunk +1 line, -1 line 0 comments Download
M courgette/encode_decode_unittest.cc View 3 chunks +17 lines, -12 lines 0 comments Download
M courgette/encoded_program.h View 3 chunks +15 lines, -11 lines 0 comments Download
M courgette/encoded_program.cc View 1 7 chunks +53 lines, -12 lines 0 comments Download
M courgette/encoded_program_fuzz_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M courgette/ensemble_apply.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M courgette/ensemble_create.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M courgette/patch_generator_x86_32.h View 1 chunk +3 lines, -3 lines 0 comments Download
A courgette/types_elf.h View 1 chunk +141 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dgarrett
The previous version of this was reverted because it failed to build on 32 bit ...
9 years, 1 month ago (2011-11-08 01:49:55 UTC) #1
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 1 month ago (2011-11-08 01:50:11 UTC) #2
dgarrett
LGTM
9 years, 1 month ago (2011-11-08 01:50:27 UTC) #3
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 1 month ago (2011-11-08 01:50:38 UTC) #4
dgarrett
9 years, 1 month ago (2011-11-08 01:51:00 UTC) #5
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 1 month ago (2011-11-08 01:51:08 UTC) #6
dgarrett
Or I won't push it directly. I have built this code for Linux 32 without ...
9 years, 1 month ago (2011-11-08 01:58:11 UTC) #7
sra1
lgtm
9 years, 1 month ago (2011-11-08 03:59:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgarrett@chromium.org/8477045/2001
9 years, 1 month ago (2011-11-08 18:34:34 UTC) #9
commit-bot: I haz the power
9 years, 1 month ago (2011-11-08 20:32:28 UTC) #10
Change committed as 109089

Powered by Google App Engine
This is Rietveld 408576698