chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm - Issue 8477042: Move Sad Tab implementation out of the TabContentsViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm

Issue 8477042: Move Sad Tab implementation out of the TabContentsViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mac unit test Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm ('k') | chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm » ('j') | chrome/browser/ui/sad_tab_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm

index 0ddf62f97efb07933de304d9d34ac17820d3fa16..2694d1d37a4e02fb78c84963b14b16e8be0953fc 100644

--- a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm

@@ -52,13 +52,13 @@ class SadTabControllerTest : public ChromeRenderViewHostTestHarness {

// Creates the controller and adds its view to contents, caller has ownership.

SadTabController* CreateController() {

- NSView* contentView = [test_window_ contentView];

SadTabController* controller =

- [[SadTabController alloc] initWithTabContents:contents()

- superview:contentView];

+ [[SadTabController alloc] initWithTabContents:contents()];

EXPECT_TRUE(controller);

NSView* view = [controller view];

EXPECT_TRUE(view);

+ NSView* contentView = [test_window_ contentView];

+ [contentView addSubview:view];

return controller;

}