Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: content/browser/tab_contents/tab_contents_view_win.cc

Issue 8477042: Move Sad Tab implementation out of the TabContentsViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: changes for jochen and jam Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/tab_contents/tab_contents_view_win.h ('k') | content/test/test_tab_contents_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/tab_contents_view_win.cc
diff --git a/content/browser/tab_contents/tab_contents_view_win.cc b/content/browser/tab_contents/tab_contents_view_win.cc
index 45d4c0f6ffd7f0075fcec0acf893f2a9482a035f..0dc9826fb10b17ff6ccd3c204df217e7a7c5d900 100644
--- a/content/browser/tab_contents/tab_contents_view_win.cc
+++ b/content/browser/tab_contents/tab_contents_view_win.cc
@@ -74,6 +74,8 @@ void TabContentsViewWin::SetPageTitle(const string16& title) {
void TabContentsViewWin::OnTabCrashed(base::TerminationStatus status,
int error_code) {
+ // TODO(avi): No other TCV implementation does anything in this callback. Can
+ // this be moved elsewhere so that |OnTabCrashed| can be removed everywhere?
view_ = NULL;
}
@@ -147,6 +149,14 @@ void TabContentsViewWin::GetViewBounds(gfx::Rect* out) const {
*out = gfx::Rect(r);
}
+void TabContentsViewWin::InstallOverlayView(gfx::NativeView view) {
+ NOTREACHED();
+}
+
+void TabContentsViewWin::RemoveOverlayView() {
+ NOTREACHED();
+}
+
void TabContentsViewWin::CreateNewWindow(
int route_id,
const ViewHostMsg_CreateWindow_Params& params) {
« no previous file with comments | « content/browser/tab_contents/tab_contents_view_win.h ('k') | content/test/test_tab_contents_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698