content/browser/tab_contents/tab_contents.cc - Issue 8477042: Move Sad Tab implementation out of the TabContentsViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 8477042: Move Sad Tab implementation out of the TabContentsViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: changes for jochen and jam Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/tab_contents/tab_contents.cc

diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc

index 34d068d9764c8227b69c35f53aa5f74a19a966f4..29ee18cbbf69011709616ec98287a8e0d9af3d87 100644

--- a/content/browser/tab_contents/tab_contents.cc

+++ b/content/browser/tab_contents/tab_contents.cc

@@ -1487,7 +1487,9 @@ void TabContents::RenderViewGone(RenderViewHost* rvh,

SetIsCrashed(status, error_code);

view()->OnTabCrashed(crashed_status(), crashed_error_code());

- FOR_EACH_OBSERVER(TabContentsObserver, observers_, RenderViewGone());

+ FOR_EACH_OBSERVER(TabContentsObserver,

+ observers_,

+ RenderViewGone(crashed_status()));

}

void TabContents::RenderViewDeleted(RenderViewHost* rvh) {