chrome/browser/ui/tab_contents/tab_contents_wrapper.cc - Issue 8477042: Move Sad Tab implementation out of the TabContentsViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

Issue 8477042: Move Sad Tab implementation out of the TabContentsViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: changes for jochen and jam Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

diff --git a/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc b/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

index 110f29e1f315d08460ccddd36049d07ce6124371..aa4fb0a4d8ab0beac83cdbcc44a5d339907cce29 100644

--- a/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

+++ b/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

@@ -47,6 +47,7 @@

#include "chrome/browser/ui/find_bar/find_tab_helper.h"

#include "chrome/browser/ui/intents/web_intent_picker_factory_impl.h"

#include "chrome/browser/ui/intents/web_intent_picker_controller.h"

+#include "chrome/browser/ui/sad_tab_observer.h"

#include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper_delegate.h"

#include "chrome/common/chrome_notification_types.h"

@@ -306,6 +307,7 @@ TabContentsWrapper::TabContentsWrapper(TabContents* contents)

external_protocol_observer_.reset(new ExternalProtocolObserver(contents));

plugin_observer_.reset(new PluginObserver(this));

print_preview_.reset(new printing::PrintPreviewMessageHandler(contents));

+ sad_tab_observer_.reset(new SadTabObserver(contents));

// Start the in-browser thumbnailing if the feature is enabled.

if (switches::IsInBrowserThumbnailingEnabled()) {

thumbnail_generation_observer_.reset(new ThumbnailGenerator);