chrome/browser/automation/automation_tab_helper.h - Issue 8477042: Move Sad Tab implementation out of the TabContentsViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_tab_helper.h

Issue 8477042: Move Sad Tab implementation out of the TabContentsViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: changes for jochen and jam Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/automation_tab_helper.h

diff --git a/chrome/browser/automation/automation_tab_helper.h b/chrome/browser/automation/automation_tab_helper.h

index a8ddef7e09598814ba1c7b2ca3802dfd111fb0bc..ae764ba90912523a3b99adf9edba7a4414684404 100644

--- a/chrome/browser/automation/automation_tab_helper.h

+++ b/chrome/browser/automation/automation_tab_helper.h

@@ -106,11 +106,11 @@ class AutomationTabHelper

const std::string& error_msg);

// TabContentsObserver implementation.

- virtual void DidStartLoading();

- virtual void DidStopLoading();

- virtual void RenderViewGone();

- virtual void TabContentsDestroyed(TabContents* tab_contents);

- virtual bool OnMessageReceived(const IPC::Message& message);

+ virtual void DidStartLoading() OVERRIDE;

+ virtual void DidStopLoading() OVERRIDE;

+ virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE;

+ virtual void TabContentsDestroyed(TabContents* tab_contents) OVERRIDE;

+ virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

void OnWillPerformClientRedirect(int64 frame_id, double delay_seconds);

void OnDidCompleteOrCancelClientRedirect(int64 frame_id);

« no previous file with comments | « no previous file | chrome/browser/automation/automation_tab_helper.cc » ('j') | no next file with comments »