Move Sad Tab implementation out of the TabContentsViews.

content/browser/tab_contents/tab_contents_view_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents_view_win.h"
 
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/renderer_host/render_widget_host_view_win.h"
 #include "content/browser/tab_contents/interstitial_page.h"
 #include "content/browser/tab_contents/tab_contents.h"
@@ skipping 56 matching lines @@
   POINT point = { r.left, r.top };
   ClientToScreen(hwnd(), &point);
   *out = gfx::Rect(point.x, point.y, r.right - r.left, r.bottom - r.top);
 }
 
 void TabContentsViewWin::SetPageTitle(const string16& title) {
 }
 
 void TabContentsViewWin::OnTabCrashed(base::TerminationStatus status,
                                       int error_code) {
+  // TODO(avi): No other TCV implementation does anything in this callback. Can
+  // this be moved elsewhere so that |OnTabCrashed| can be removed everywhere?

[jam, 2011/11/14 19:56:28]

perhaps :) I had to add this to avoid dereferencing a null views_ after a tab
crashed. I can look into moving this elsewhere

   view_ = NULL;
 }
 
 void TabContentsViewWin::SizeContents(const gfx::Size& size) {
   gfx::Rect bounds;
   GetContainerBounds(&bounds);
   if (bounds.size() != size) {
     SetWindowPos(hwnd(), NULL, 0, 0, size.width(), size.height(),
                  SWP_NOACTIVATE | SWP_NOZORDER | SWP_NOMOVE);
   } else {
@@ skipping 53 matching lines @@
 
 void TabContentsViewWin::CloseTabAfterEventTracking() {
 }
 
 void TabContentsViewWin::GetViewBounds(gfx::Rect* out) const {
   RECT r;
   GetWindowRect(hwnd(), &r);
   *out = gfx::Rect(r);
 }
 
+void TabContentsViewWin::InstallOverlayView(gfx::NativeView view) {
+  NOTREACHED();
+}
+
+void TabContentsViewWin::RemoveOverlayView() {
+  NOTREACHED();
+}
+
 void TabContentsViewWin::CreateNewWindow(
     int route_id,
     const ViewHostMsg_CreateWindow_Params& params) {
   TabContents* tab = delegate_->CreateNewWindow(this, route_id, params);
 
   // Copy logic from RenderViewHostDelegateViewHelper.
   TabContentsView* new_view = tab->view();
   new_view->CreateViewForWidget(tab->render_view_host());
   pending_contents_[route_id] = tab->render_view_host();
 }
@@ skipping 73 matching lines @@
 
   gfx::Size size(window_pos->cx, window_pos->cy);
   if (tab_contents_->interstitial_page())
     tab_contents_->interstitial_page()->SetSize(size);
   RenderWidgetHostView* rwhv = tab_contents_->GetRenderWidgetHostView();
   if (rwhv)
     rwhv->SetSize(size);
 
   return 0;
 }