Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm

Issue 8477042: Move Sad Tab implementation out of the TabContentsViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: OVERRIDE saves my butt again Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h" 5 #include "chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h"
6 6
7 #include "base/mac/mac_util.h" 7 #include "base/mac/mac_util.h"
8 #import "chrome/browser/ui/cocoa/tab_contents/sad_tab_view.h" 8 #import "chrome/browser/ui/cocoa/tab_contents/sad_tab_view.h"
9 9
10 namespace sad_tab_controller_mac {
11 SadTabController* CreateSadTabController(TabContents* tab_contents) {
12 return [[SadTabController alloc] initWithTabContents:tab_contents];
13 }
jochen (gone - plz use gerrit) 2011/11/14 16:44:54 empty line after this
14 gfx::NativeView ViewOfSadTabController(SadTabController* sad_tab) {
15 return [sad_tab view];
16 }
17 }
jochen (gone - plz use gerrit) 2011/11/14 16:44:54 // namespace sad_tab_controller_mac
18
10 @implementation SadTabController 19 @implementation SadTabController
11 20
12 - (id)initWithTabContents:(TabContents*)someTabContents 21 - (id)initWithTabContents:(TabContents*)tabContents {
13 superview:(NSView*)superview {
14 if ((self = [super initWithNibName:@"SadTab" 22 if ((self = [super initWithNibName:@"SadTab"
15 bundle:base::mac::MainAppBundle()])) { 23 bundle:base::mac::MainAppBundle()])) {
16 tabContents_ = someTabContents; 24 tabContents_ = tabContents;
17
18 NSView* view = [self view];
19 [superview addSubview:view];
20 [view setFrame:[superview bounds]];
21 } 25 }
22 26
23 return self; 27 return self;
24 } 28 }
25 29
26 - (void)awakeFromNib { 30 - (void)awakeFromNib {
27 // If tab_contents_ is nil, ask view to remove link. 31 // If tab_contents_ is nil, ask view to remove link.
28 if (!tabContents_) { 32 if (!tabContents_) {
29 SadTabView* sad_view = static_cast<SadTabView*>([self view]); 33 SadTabView* sad_view = static_cast<SadTabView*>([self view]);
30 [sad_view removeHelpText]; 34 [sad_view removeHelpText];
31 } 35 }
32 } 36 }
33 37
34 - (void)dealloc {
35 [[self view] removeFromSuperview];
36 [super dealloc];
37 }
38
39 - (TabContents*)tabContents { 38 - (TabContents*)tabContents {
40 return tabContents_; 39 return tabContents_;
41 } 40 }
42 41
43 - (void)openLearnMoreAboutCrashLink:(id)sender { 42 - (void)openLearnMoreAboutCrashLink:(id)sender {
44 // Send the action up through the responder chain. 43 // Send the action up through the responder chain.
45 [NSApp sendAction:@selector(openLearnMoreAboutCrashLink:) to:nil from:self]; 44 [NSApp sendAction:@selector(openLearnMoreAboutCrashLink:) to:nil from:self];
46 } 45 }
47 46
48 @end 47 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698