Issue 8477030: Ensure that promotion queue does not overlap with objects relocated to ToSpace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8477030: Ensure that promotion queue does not overlap with objects relocated to ToSpace. (Closed)

Created:
9 years, 1 month ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 1 month ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Ensure that promotion queue does not overlap with objects relocated to ToSpace. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=9932

Patch Set 2 : try to minimize regressions #

Patch Set 4 : remove wrong assertion #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+168 lines, -42 lines)			Patch
M	src/heap.h	View	1 2 3	2 chunks	+61 lines, -10 lines	0 comments	Download
M	src/heap.cc	View	1	5 chunks	+40 lines, -2 lines	0 comments	Download
M	src/heap-inl.h	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download
M	src/spaces.h	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	src/spaces.cc	View	1	2 chunks	+36 lines, -3 lines	0 comments	Download
M	src/spaces-inl.h	View		1 chunk	+4 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/8477030/diff/1/SConstruct File SConstruct (right): http://codereview.chromium.org/8477030/diff/1/SConstruct#newcode97 SConstruct:97: 'CCFLAGS': ['-O3', '-g'], You probably do not want ...

9 years, 1 month ago (2011-11-07 16:35:25 UTC) #2

LGTM