[filebrowser] Improve scrolling by converting some async calls to sync.

[filebrowser] Improve scrolling by converting some async calls to sync.

BUG=chromium-os:20416
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109863

[dgozman, 2011-11-07 13:37:59]

Please, take a look.

[Vladislav Kaznacheev, 2011-11-08 09:33:31]

LGTM with nits

http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:428: function
cacheEntrySize(entry, successCallback, opt_errorCallback, opt_sync) {
Please update JSDoc

http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:436: // Callback via a
setTimeout so the sync/async semantics don't change
Comment is now obsolete here and below. Here is an idea: why don't we extract an
utility function invokeCallback(callback, opt_sync) and use it in the three
places? And comment why we need it?

http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:466: function
cacheEntryDate(entry, successCallback, opt_errorCallback, opt_sync) {
Please update JSDoc

[dgozman, 2011-11-14 09:59:26]

Please, look once again.

http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:428: function
cacheEntrySize(entry, successCallback, opt_errorCallback, opt_sync) {
On 2011/11/08 09:33:31, Vladislav Kaznacheev wrote:
> Please update JSDoc

Done.

http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:436: // Callback via a
setTimeout so the sync/async semantics don't change
On 2011/11/08 09:33:31, Vladislav Kaznacheev wrote:
> Comment is now obsolete here and below. Here is an idea: why don't we extract
an
> utility function invokeCallback(callback, opt_sync) and use it in the three
> places? And comment why we need it?

Done.

http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:466: function
cacheEntryDate(entry, successCallback, opt_errorCallback, opt_sync) {
On 2011/11/08 09:33:32, Vladislav Kaznacheev wrote:
> Please update JSDoc

Done.

[Vladislav Kaznacheev, 2011-11-14 10:19:10]

On 2011/11/14 09:59:26, dgozman wrote:
> Please, look once again.
> 
> 
LGTM
http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
> File chrome/browser/resources/file_manager/js/file_manager.js (right):
> 
>
http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
> chrome/browser/resources/file_manager/js/file_manager.js:428: function
> cacheEntrySize(entry, successCallback, opt_errorCallback, opt_sync) {
> On 2011/11/08 09:33:31, Vladislav Kaznacheev wrote:
> > Please update JSDoc
> 
> Done.
> 
>
http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
> chrome/browser/resources/file_manager/js/file_manager.js:436: // Callback via
a
> setTimeout so the sync/async semantics don't change
> On 2011/11/08 09:33:31, Vladislav Kaznacheev wrote:
> > Comment is now obsolete here and below. Here is an idea: why don't we
extract
> an
> > utility function invokeCallback(callback, opt_sync) and use it in the three
> > places? And comment why we need it?
> 
> Done.
> 
>
http://codereview.chromium.org/8477027/diff/1/chrome/browser/resources/file_m...
> chrome/browser/resources/file_manager/js/file_manager.js:466: function
> cacheEntryDate(entry, successCallback, opt_errorCallback, opt_sync) {
> On 2011/11/08 09:33:32, Vladislav Kaznacheev wrote:
> > Please update JSDoc
> 
> Done.

[commit-bot: I haz the power, 2011-11-14 10:27:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/8477027/4001

[commit-bot: I haz the power, 2011-11-14 11:36:53]

Change committed as 109863