chrome/common/mac/cfbundle_blocker.mm - Issue 8477018: Pull back some CHECK calls which were removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/mac/cfbundle_blocker.mm

Issue 8477018: Pull back some CHECK calls which were removed. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: comment tweak Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/mac/cfbundle_blocker.mm

diff --git a/chrome/common/mac/cfbundle_blocker.mm b/chrome/common/mac/cfbundle_blocker.mm

index c4c29f29db795a40a26847acdb08bfea07f59b3e..3dbc34f90f1973245d44612d45150ae041113010 100644

--- a/chrome/common/mac/cfbundle_blocker.mm

+++ b/chrome/common/mac/cfbundle_blocker.mm

@@ -175,12 +175,14 @@ Boolean ChromeCFBundleLoadExecutableAndReturnError(CFBundleRef bundle,

NSString* bundle_id_print = bundle_id ? bundle_id : @"(nil)";

NSString* version_print = version ? version : @"(nil)";

- DLOG(INFO) << "Blocking attempt to load bundle "

- << [bundle_id_print UTF8String]

- << " version "

- << [version_print UTF8String]

- << " at "

- << [path fileSystemRepresentation];

+ // Provide a hint for the user (or module developer) to figure out

+ // that the bundle was blocked.

+ LOG(INFO) << "Blocking attempt to load bundle "

+ << [bundle_id_print UTF8String]

+ << " version "

+ << [version_print UTF8String]

+ << " at "

+ << [path fileSystemRepresentation];

if (error) {

base::mac::ScopedCFTypeRef<CFStringRef> app_bundle_id(

« no previous file with comments | « chrome/common/important_file_writer.cc ('k') | chrome/common/multi_process_lock_linux.cc » ('j') | no next file with comments »