Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9767)

Unified Diff: chrome/common/important_file_writer.cc

Issue 8477018: Pull back some CHECK calls which were removed. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/mac/cfbundle_blocker.mm » ('j') | chrome/common/mac/objc_zombie.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/important_file_writer.cc
diff --git a/chrome/common/important_file_writer.cc b/chrome/common/important_file_writer.cc
index c5e4cf8cd5272dcf34b166499a6afb347d8fffc5..80789b09ecbad0186e3a10fda5d6f9430e846f9a 100644
--- a/chrome/common/important_file_writer.cc
+++ b/chrome/common/important_file_writer.cc
@@ -50,7 +50,8 @@ class WriteToDiskTask : public Task {
return;
}
- DCHECK_LE(data_.length(), static_cast<size_t>(kint32max));
+ // If happens in the wild something really bad is likely to be going on.
Mark Mentovai 2011/11/05 00:49:02 If happens -> if this happens?
Scott Hess - ex-Googler 2011/11/08 18:47:51 Done.
+ CHECK_LE(data_.length(), static_cast<size_t>(kint32max));
int bytes_written = base::WritePlatformFile(
tmp_file, 0, data_.data(), static_cast<int>(data_.length()));
base::FlushPlatformFile(tmp_file); // Ignore return value.
« no previous file with comments | « no previous file | chrome/common/mac/cfbundle_blocker.mm » ('j') | chrome/common/mac/objc_zombie.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698