chrome/browser/ui/views/extensions/extension_popup.cc - Issue 8477004: Have content/ create and destroy its own threads.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 8477004: Have content/ create and destroy its own threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More IWYU, missing link-time dependency for Chrome Frame. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/gtk/dialogs_kde.cc ('K') | « chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc ('k') | chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc » ('j') | content/browser/browser_main_loop.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/extensions/extension_popup.h"	5 #include "chrome/browser/ui/views/extensions/extension_popup.h"

6	6

7 #include <vector>	7 #include <vector>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

	10 #include "base/message_loop.h"

10 #include "chrome/browser/debugger/devtools_window.h"	11 #include "chrome/browser/debugger/devtools_window.h"

11 #include "chrome/browser/extensions/extension_host.h"	12 #include "chrome/browser/extensions/extension_host.h"

12 #include "chrome/browser/extensions/extension_process_manager.h"	13 #include "chrome/browser/extensions/extension_process_manager.h"

13 #include "chrome/browser/profiles/profile.h"	14 #include "chrome/browser/profiles/profile.h"

14 #include "chrome/browser/ui/browser.h"	15 #include "chrome/browser/ui/browser.h"

15 #include "chrome/browser/ui/browser_window.h"	16 #include "chrome/browser/ui/browser_window.h"

16 #include "chrome/common/chrome_notification_types.h"	17 #include "chrome/common/chrome_notification_types.h"

17 #include "chrome/common/extensions/extension.h"	18 #include "chrome/common/extensions/extension.h"

18 #include "content/browser/renderer_host/render_view_host.h"	19 #include "content/browser/renderer_host/render_view_host.h"

19 #include "content/browser/renderer_host/render_widget_host_view.h"	20 #include "content/browser/renderer_host/render_widget_host_view.h"

(...skipping 185 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
205 if (closing_)	206 if (closing_)

206 return;	207 return;

207 closing_ = true;	208 closing_ = true;

208 DetachFromBrowser();	209 DetachFromBrowser();

209	210

210 if (observer_)	211 if (observer_)

211 observer_->ExtensionPopupIsClosing(this);	212 observer_->ExtensionPopupIsClosing(this);

212	213

213 Release(); // Balanced in ctor.	214 Release(); // Balanced in ctor.

214 }	215 }

OLD	NEW