ui/gfx/render_text.cc - Issue 8476019: ui/gfx: Convert Canvas::DrawRectInt() to use gfx::Rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text.cc

Issue 8476019: ui/gfx: Convert Canvas::DrawRectInt() to use gfx::Rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address Peter's review Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text.cc

diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc

index b6fb3590c76bea025a3c82fbda18c618b65e8881..3f9f91ad4c9326082371b9709877e3dd954e229f 100644

--- a/ui/gfx/render_text.cc

+++ b/ui/gfx/render_text.cc

@@ -387,10 +387,8 @@ void RenderText::Draw(Canvas* canvas) {

}

// Paint cursor. Replace cursor is drawn as rectangle for now.

- Rect cursor(GetUpdatedCursorBounds());

if (cursor_visible() && focused())

- canvas->DrawRectInt(kCursorColor, cursor.x(), cursor.y(),

- cursor.width(), cursor.height());

+ canvas->DrawRect(GetUpdatedCursorBounds(), kCursorColor);

}

SelectionModel RenderText::FindCursorPosition(const Point& point) {