Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: ui/gfx/canvas_skia.h

Issue 8476019: ui/gfx: Convert Canvas::DrawRectInt() to use gfx::Rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address Peter's review Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/gfx/canvas.h ('K') | « ui/gfx/canvas.h ('k') | ui/gfx/canvas_skia.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/canvas_skia.h
diff --git a/ui/gfx/canvas_skia.h b/ui/gfx/canvas_skia.h
index 05d482499d4f7f63d36f85217290f10ab7842e5a..e831b1537ddc515b318a12e93df92447e6125f8a 100644
--- a/ui/gfx/canvas_skia.h
+++ b/ui/gfx/canvas_skia.h
@@ -109,13 +109,11 @@ class UI_EXPORT CanvasSkia : public Canvas {
SkXfermode::Mode mode) OVERRIDE;
virtual void FillRect(const gfx::Brush* brush,
const gfx::Rect& rect) OVERRIDE;
- virtual void DrawRectInt(const SkColor& color,
- int x, int y, int w, int h) OVERRIDE;
- virtual void DrawRectInt(const SkColor& color,
- int x, int y, int w, int h,
- SkXfermode::Mode mode) OVERRIDE;
- virtual void DrawRectInt(int x, int y, int w, int h,
- const SkPaint& paint) OVERRIDE;
+ virtual void DrawRect(const gfx::Rect& rect, const SkPaint& paint) OVERRIDE;
Peter Kasting 2011/11/21 19:26:03 Nit: Same comment about order
tfarina 2011/11/22 18:39:01 Done.
+ virtual void DrawRect(const gfx::Rect& rect, const SkColor& color) OVERRIDE;
+ virtual void DrawRect(const gfx::Rect& rect,
+ const SkColor& color,
+ SkXfermode::Mode mode) OVERRIDE;
virtual void DrawLineInt(const SkColor& color,
int x1, int y1,
int x2, int y2) OVERRIDE;
« ui/gfx/canvas.h ('K') | « ui/gfx/canvas.h ('k') | ui/gfx/canvas_skia.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698