chrome/browser/ui/views/tabs/tab_strip.cc - Issue 8476019: ui/gfx: Convert Canvas::DrawRectInt() to use gfx::Rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 8476019: ui/gfx: Convert Canvas::DrawRectInt() to use gfx::Rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address Peter's review Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/tab_strip.cc

diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc

index 349ef15c22b16d291328ec8eead28904448a9b9a..302ff556b30e3e659af8996b3c19eebf3f6df8e5 100644

--- a/chrome/browser/ui/views/tabs/tab_strip.cc

+++ b/chrome/browser/ui/views/tabs/tab_strip.cc

@@ -333,9 +333,8 @@ void TabStrip::PaintChildren(gfx::Canvas* canvas) {

multiple_tabs_selected ? 150 : 200, 255, 255, 255));

paint.setXfermodeMode(SkXfermode::kDstIn_Mode);

paint.setStyle(SkPaint::kFill_Style);

- canvas->DrawRectInt(0, 0, width(),

- height() - 2, // Visible region that overlaps the toolbar.

- paint);

+ // The tabstrip area overlaps the toolbar area by 2 px.

+ canvas->DrawRect(gfx::Rect(0, 0, width(), height() - 2), paint);

}

// Now selected but not active. We don't want these dimmed if using native