Issue 8476013: Don't initialize GL bindings in browser process even if libpic doesn't exist on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8476013: Don't initialize GL bindings in browser process even if libpic doesn't exist on Linux. (Closed)

Created:
9 years, 1 month ago by Zhenyao Mo

Modified:
9 years, 1 month ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't initialize GL bindings in browser process even if libpci doesn't exist on Linux. Initializing GL bindings seems to crash chrome sometime with fglrx drivers. We should definitely avoid that. So the ATI cards we want to blacklist cannot be done at through preliminary gpu info collection, but it can be done at GPU process launch time. We use GL_VENDOR and GL_RENDERER string for blacklisting rather than vendor_id. BUG=94973 TEST=unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108739

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -47 lines)			Patch
	M	chrome/browser/resources/software_rendering_list.json	View		2 chunks	+52 lines, -10 lines	0 comments	Download
	M	content/gpu/gpu_info_collector_linux.cc	View		3 chunks	+0 lines, -37 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

9 years, 1 month ago (2011-11-04 23:20:23 UTC) #2

In the synopsis, please correct the typo: libpic -> libpci

LGTM as long as it's been tested. I'm not convinced that the existing unit tests
are sufficient to cover regressions. Ideally they would be expanded to cover the
case where the preliminary GPU info doesn't cause the card to be blacklisted but
the full GPU info does.

Expand Messages | Collapse Messages