chrome/browser/ui/views/status_icons/status_tray_linux.cc - Issue 8476003: Implement the status tray/icon API for ChromeOS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/status_icons/status_tray_linux.cc

Issue 8476003: Implement the status tray/icon API for ChromeOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressing Steven's comments. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/views/status_icons/status_icon_chromeos.h ('K') | « chrome/browser/ui/views/status_icons/status_tray_chromeos_browsertest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/status_icons/status_tray.h"	5 #include "chrome/browser/status_icons/status_tray.h"

6	6

	7 #if !defined(OS_CHROMEOS)
	Andrew T Wilson (Slow) 2011/11/17 21:32:31 I have no strong objections to this, but it's some I have no strong objections to this, but it's somewhat troubling to me that we're adding this here when it shouldn't (in theory) be needed, as that may indicate we're not properly setting up our .gyp file. Can you please confirm it's necessary? Leandro Graciá Gil 2011/11/17 22:42:45 This was checked this with Steven because of link Show quoted text On 2011/11/17 21:32:31, Andrew T Wilson wrote: > I have no strong objections to this, but it's somewhat troubling to me that > we're adding this here when it shouldn't (in theory) be needed, as that may > indicate we're not properly setting up our .gyp file. Can you please confirm > it's necessary? This was checked this with Steven because of link errors with the linux aura bot. This seems to be the simplest way to solve the problem.
	8

7 // Status icons are not currently supported on linux/views or Aura.	9 // Status icons are not currently supported on linux/views or Aura.

8 StatusTray* StatusTray::Create() {	10 StatusTray* StatusTray::Create() {

9 return NULL;	11 return NULL;

10 }	12 }

	13

	14 #endif

OLD	NEW