Changed argument to GetAcceptLangs() to a BrowserContext.

Changed argument to GetAcceptLangs() to a BrowserContext.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110719

[Randy Smith (Not in Mondays), 2011-11-05 14:17:14]

John: After I sent you my email, I decided that it was an easy enough change to
make I'd just upload a CL and let you comment there.  

Context for others: I have a long-term low-priority goal of removing the
dependency of a download being associated with a particular tab (downloads are
per-profile/browser context objects, not really per-tab objects).  Changing the
argument of GetAcceptLangs() to BrowserContext would help that goal.

[jam, 2011-11-07 16:56:38]

lgtm

http://codereview.chromium.org/8475024/diff/1/content/browser/download/downlo...
File content/browser/download/download_item.cc (right):

http://codereview.chromium.org/8475024/diff/1/content/browser/download/downlo...
content/browser/download/download_item.cc:647: if (tab)
nit: add brace brackets now

[Randy Smith (Not in Mondays), 2011-11-15 21:43:49]

Sorry, John, quick re-review.  I was having compile problems, for which the
simplest way to fix the problem was to make the argument to GetAcceptLangs()
non-const.  Conceptually, there's not a lot of reason for this, but it would
require a fair amount of change to drive the spike through, and the result of
TabContents::browser_context() wasn't const.  That change ok by you?

[Randy Smith (Not in Mondays), 2011-11-17 16:52:05]

jam: Ping?

On 2011/11/15 21:43:49, rdsmith wrote:
> Sorry, John, quick re-review.  I was having compile problems, for which the
> simplest way to fix the problem was to make the argument to GetAcceptLangs()
> non-const.  Conceptually, there's not a lot of reason for this, but it would
> require a fair amount of change to drive the spike through, and the result of
> TabContents::browser_context() wasn't const.  That change ok by you?

[jam, 2011-11-18 01:36:30]

lgtm

[commit-bot: I haz the power, 2011-11-18 15:36:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/8475024/11001

[commit-bot: I haz the power, 2011-11-18 18:31:22]

Change committed as 110719