client/html/generated/src/interface/CanvasPixelArray.dart - Issue 8475009: Proposed canvas and WebGL cleanup

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: client/html/generated/src/interface/CanvasPixelArray.dart

Issue 8475009: Proposed canvas and WebGL cleanup (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: ready to discuss Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | client/html/generated/src/interface/CanvasRenderingContext2D.dart » ('j') | client/html/generated/src/interface/CanvasRenderingContext2D.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 // WARNING: Do not edit - generated code.	5 // WARNING: Do not edit - generated code.

6	6

	7 // TODO(jacobr): should we remove this class completely or

	8 // add additional helper methods like
	vsm 2011/11/04 21:26:35 If we remove this, do you have an alternative sche If we remove this, do you have an alternative scheme in mind for direct access to the underlying buffer? Jacob 2011/11/04 22:26:13 You should still be able to directly access the un Show quoted text On 2011/11/04 21:26:35, vsm wrote: > If we remove this, do you have an alternative scheme in mind for direct access > to the underlying buffer? You should still be able to directly access the underlying buffer by calling yourCanvasPixels[index] I don't see anywhere in the DOM were you can pass a CanvasPixelArray back to the DOM so there isn't a need to have a user visible type for this other than List<int> as far as I can see. However, having a marker type for this could have a little bit of value to ease debugging I guess.
	9 // Color getPixel(int index)

	10 // or

	11 // void setPixel(int r, int g, int b, int a, int index);

7 interface CanvasPixelArray extends List<int> {	12 interface CanvasPixelArray extends List<int> {

8

9 int get length();

10

11 int item(int index);

12 }	13 }

OLD	NEW