Issue 8473010: Mark a cookie as session cookie, if the expiry date cannot be parsed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8473010: Mark a cookie as session cookie, if the expiry date cannot be parsed (Closed)

Created:
9 years, 1 month ago by jochen (gone - plz use gerrit)

Modified:
9 years, 1 month ago

Reviewers:
erikwright (departed)

CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), Paweł Hajdan Jr., wtc, darin-cc_chromium.org, rkn, marja

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Mark a cookie as session cookie, if the expiry date cannot be parsed BUG=104813 TEST=CookieManagerTest.InvalidExpiryTime Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111188

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	net/base/cookie_monster.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/base/cookie_monster_unittest.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Randy Smith (Not in Mondays)

On 2011/11/22 17:05:40, erikwright wrote: > LGTM. Rubberstamp LGTM based on Erik's LGTM.

9 years, 1 month ago (2011-11-22 17:07:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8473010/1

9 years, 1 month ago (2011-11-22 17:11:27 UTC) #4

Change committed as 111188