Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5289)

Unified Diff: chrome/browser/extensions/extension_browser_actions_api.h

Issue 8473003: Add OVERRIDE to chrome/browser/extensions/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_app_api.h ('k') | chrome/browser/extensions/extension_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_browser_actions_api.h
diff --git a/chrome/browser/extensions/extension_browser_actions_api.h b/chrome/browser/extensions/extension_browser_actions_api.h
index 127ad4a070ece7d595bf95bfee11f50f4ab94f24..11323545f949d4d6849cd57bc9d34569b309d797 100644
--- a/chrome/browser/extensions/extension_browser_actions_api.h
+++ b/chrome/browser/extensions/extension_browser_actions_api.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -23,7 +23,7 @@ class BrowserActionFunction : public SyncExtensionFunction {
tab_id_(ExtensionAction::kDefaultTabId),
browser_action_(NULL) {}
virtual ~BrowserActionFunction() {}
- virtual bool RunImpl();
+ virtual bool RunImpl() OVERRIDE;
virtual bool RunBrowserAction() = 0;
// All the browser action APIs take a single argument called details that is
@@ -41,28 +41,28 @@ class BrowserActionFunction : public SyncExtensionFunction {
// Implement chrome.browserAction.setIcon().
class BrowserActionSetIconFunction : public BrowserActionFunction {
virtual ~BrowserActionSetIconFunction() {}
- virtual bool RunBrowserAction();
+ virtual bool RunBrowserAction() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setIcon")
};
// Implement chrome.browserAction.setTitle().
class BrowserActionSetTitleFunction : public BrowserActionFunction {
virtual ~BrowserActionSetTitleFunction() {}
- virtual bool RunBrowserAction();
+ virtual bool RunBrowserAction() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setTitle")
};
// Implement chrome.browserActions.setPopup().
class BrowserActionSetPopupFunction : public BrowserActionFunction {
virtual ~BrowserActionSetPopupFunction() {}
- virtual bool RunBrowserAction();
+ virtual bool RunBrowserAction() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setPopup")
};
// Implement chrome.browserAction.setBadgeText().
class BrowserActionSetBadgeTextFunction : public BrowserActionFunction {
virtual ~BrowserActionSetBadgeTextFunction() {}
- virtual bool RunBrowserAction();
+ virtual bool RunBrowserAction() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setBadgeText")
};
@@ -70,7 +70,7 @@ class BrowserActionSetBadgeTextFunction : public BrowserActionFunction {
class BrowserActionSetBadgeBackgroundColorFunction
: public BrowserActionFunction {
virtual ~BrowserActionSetBadgeBackgroundColorFunction() {}
- virtual bool RunBrowserAction();
+ virtual bool RunBrowserAction() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setBadgeBackgroundColor")
};
« no previous file with comments | « chrome/browser/extensions/extension_app_api.h ('k') | chrome/browser/extensions/extension_browsertest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698