Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 8473001: Show missing plug-in infobar only if a plug-in is available. (Closed)

Created:
9 years, 1 month ago by Bernhard Bauer
Modified:
9 years, 1 month ago
Reviewers:
ananta
CC:
chromium-reviews
Visibility:
Public.

Description

Show missing plug-in infobar only if a plug-in is available. BUG=101821 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M chrome/default_plugin/plugin_impl_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/default_plugin/plugin_impl_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/default_plugin/plugin_impl_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/default_plugin/plugin_impl_win.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M chrome/default_plugin/plugin_installer_base.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/default_plugin/plugin_installer_base.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
Please review.
9 years, 1 month ago (2011-11-04 14:25:59 UTC) #1
ananta
LGTM
9 years, 1 month ago (2011-11-04 17:54:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/8473001/1
9 years, 1 month ago (2011-11-04 18:16:19 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-04 20:46:47 UTC) #4
Change committed as 108705

Powered by Google App Engine
This is Rietveld 408576698