Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 8472006: Use -fasan together with -faddress-sanitizer in nacl.gypi as well. (Closed)

Created:
9 years, 1 month ago by Alexander Potapenko
Modified:
9 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Use -fasan together with -faddress-sanitizer in nacl.gypi as well. TBR=thakis Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/nacl.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
TBR
9 years, 1 month ago (2011-11-21 15:12:49 UTC) #1
Nico
lgtm if it works :-) clang warns on unused options, so this assumes you have ...
9 years, 1 month ago (2011-11-21 16:04:05 UTC) #2
Alexander Potapenko
Clang prints the warnings, but still works: http://build.chromium.org/p/chromium.memory/builders/ASAN%20Builder/builds/4902/steps/compile/logs/stdio On Mon, Nov 21, 2011 at 8:04 ...
9 years, 1 month ago (2011-11-21 16:06:30 UTC) #3
Nico
9 years, 1 month ago (2011-11-21 16:22:18 UTC) #4
> Clang prints the warnings, but still works:
>
http://build.chromium.org/p/chromium.memory/builders/ASAN%2520Builder/builds/...

Ah, ok. Maybe send a heads-up to the memory sheriff list that these warnings are
harmless and will go away in a week or two then.

Powered by Google App Engine
This is Rietveld 408576698