Add tests for both universal_newlines=True and False.

Add tests for both universal_newlines=True and False.

Fix stdout+stderr on Windows to binary mode in the child test process to make
sure testing is done correctly.

R=dpranke@chromium.org
BUG=
TEST=manually tested on OSX, Windows, cygwin and ubuntu


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109282

[Dirk Pranke, 2011-11-09 03:36:53]

lgtm.

looks plausible. I didn't sweat the details :( .

[commit-bot: I haz the power, 2011-11-09 19:18:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8472002/1

[M-A Ruel, 2011-11-09 19:20:33]

On 2011/11/09 03:36:53, Dirk Pranke wrote:
> lgtm.
> 
> looks plausible. I didn't sweat the details :( .

FTR, I'm running each tests a few times, having the child process outputting LF,
CR, or CRLF lines, with or without universal_newlines=True. I compare the
results in an OS specific way.

Lots of manual testing but at least it's documenting the current behavior.

[commit-bot: I haz the power, 2011-11-09 19:24:49]

Change committed as 109282