Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 8471001: Include the contentSettings permission in the list of permissions triggering a warning (Closed)

Created:
9 years, 1 month ago by battre
Modified:
9 years, 1 month ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, jochen (gone - plz use gerrit), Bernhard Bauer
Visibility:
Public.

Description

"contentSettings" permission not listed in permission warnings BUG=102410 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M chrome/common/extensions/docs/permission_warnings.html View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/permission_warnings.html View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
And another missing permission... Please review.
9 years, 1 month ago (2011-11-04 12:36:54 UTC) #1
Matt Perry
lgtm
9 years, 1 month ago (2011-11-04 19:12:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8471001/1
9 years, 1 month ago (2011-11-04 19:33:11 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-04 20:45:47 UTC) #4
Change committed as 108704

Powered by Google App Engine
This is Rietveld 408576698