Issue 8470006: Enforce that most content messages files can't be included by chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8470006: Enforce that most content messages files can't be included by chrome. (Closed)

Created:
9 years, 1 month ago by jam

Modified:
9 years, 1 month ago

Reviewers:
Jói

CC:
chromium-reviews, jennb, prasadt, jam, Dmitry Titov, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, jianli, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Enforce that most content messages files can't be included by chrome. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110846

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -378 lines)			Patch
M	chrome/browser/DEPS	View	2 chunks	+40 lines, -1 line	0 comments	Download
M	chrome/browser/debugger/devtools_sanity_unittest.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
D	chrome/browser/idbbindingutilities_browsertest.cc	View	1 chunk	+0 lines, -371 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	content/browser/idbbindingutilities_browsertest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jói

9 years, 1 month ago (2011-11-19 13:20:08 UTC) #3

lgtm
(didn't see my previous LGTM via Rietveld make it through, so this is
just in case)

On Sat, Nov 19, 2011 at 2:22 AM,  <jam@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> Enforce that most content messages files can't be included by chrome.
>
> BUG=98716
>
> Please review this at http://codereview.chromium.org/8470006/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/DEPS
>  M     chrome/browser/debugger/devtools_sanity_unittest.cc
>  D     chrome/browser/idbbindingutilities_browsertest.cc
>  M     chrome/browser/ui/panels/panel_browsertest.cc
>  M     chrome/chrome_tests.gypi
>  A  +  content/browser/idbbindingutilities_browsertest.cc
>
>

Expand Messages | Collapse Messages