Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 8469019: [Aura] Update app list window. (Closed)

Created:
9 years, 1 month ago by xiyuan
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

[Aura] Update app list window. - Defer showing animation until web contents is rendered; - Properly close widget after hiding animation is finished; - Create app list window with always-on-top and transparent flags; BUG=98308 TEST=Verify showing animation could be seen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109785

Patch Set 1 #

Patch Set 2 : remove capture test code and use sky's GetLayer code #

Total comments: 1

Patch Set 3 : add comments per sky's suggestion #

Patch Set 4 : sync and resolve conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -33 lines) Patch
M chrome/browser/ui/views/aura/app_list_window.h View 1 2 5 chunks +28 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/aura/app_list_window.cc View 1 2 3 6 chunks +58 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
xiyuan
9 years, 1 month ago (2011-11-11 00:19:07 UTC) #1
sky
LGTM http://codereview.chromium.org/8469019/diff/2001/chrome/browser/ui/views/aura/app_list_window.h File chrome/browser/ui/views/aura/app_list_window.h (right): http://codereview.chromium.org/8469019/diff/2001/chrome/browser/ui/views/aura/app_list_window.h#newcode73 chrome/browser/ui/views/aura/app_list_window.h:73: bool content_rendered_; Add a description for these.
9 years, 1 month ago (2011-11-11 02:39:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8469019/6001
9 years, 1 month ago (2011-11-11 17:27:02 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/views/aura/app_list_window.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/views/aura/app_list_window.cc ...
9 years, 1 month ago (2011-11-11 18:36:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8469019/9001
9 years, 1 month ago (2011-11-11 19:52:23 UTC) #5
commit-bot: I haz the power
Try job failure for 8469019-9001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-11 20:54:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8469019/9001
9 years, 1 month ago (2011-11-12 06:34:21 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-12 07:45:53 UTC) #8
Change committed as 109785

Powered by Google App Engine
This is Rietveld 408576698