chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc - Issue 8469018: Provide assumed favicon for intents if service provider page was never visited.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc

Issue 8469018: Provide assumed favicon for intents if service provider page was never visited. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed review issues. Fixed merge issues due to MaybeShowIntentInfoBar Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/thumbnail_database.cc ('K') | « chrome/browser/intents/register_intent_handler_infobar_delegate.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc

diff --git a/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc b/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc

index c273e681efe2480980d9779dddc29261b6d609a4..d308b73afc45c368dc4890dbda796ae693c6852b 100644

--- a/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc

+++ b/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc

@@ -70,7 +70,7 @@ TEST_F(RegisterIntentHandlerInfoBarDelegateTest, Accept) {

RegisterIntentHandlerInfoBarDelegate delegate(

contents_wrapper()->infobar_tab_helper(),

WebIntentsRegistryFactory::GetForProfile(profile()),

- service);

+ service, NULL, GURL());

EXPECT_CALL(*web_intents_registry_, RegisterIntentProvider(service));

delegate.Accept();