Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: frog/gen.dart

Issue 8469016: Adding in-browser correctness testing via selenium. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/gen.dart
===================================================================
--- frog/gen.dart (revision 1427)
+++ frog/gen.dart (working copy)
@@ -324,8 +324,11 @@
writer.enterBlock('Object.defineProperty(' +
'${property.declaringType.jsname}.prototype, "${property.jsname}", {');
if (property.getter != null) {
- writer.writeln(
- 'get: ${property.declaringType.jsname}.prototype.${property.getter.jsname},');
+ writer.write(
+ 'get: ${property.declaringType.jsname}.prototype.${property.getter.jsname}');
+ // The shenanigan below is to make IE happy -- IE 9 doesn't like a
+ // trailing comma on the last element in a list.
+ writer.writeln(property.setter == null ? '' : ',');
}
if (property.setter != null) {
writer.writeln(
« no previous file with comments | « frog/frogsh ('k') | frog/var_member.dart » ('j') | tools/testing/architecture.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698