Adding in-browser correctness testing via selenium.

tools/testing/test_case.py

 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """Common TestCase subclasses used to define a single test."""
 
 import os
 import tempfile
 
 import test
@@ skipping 42 matching lines @@
 
   def GetSource(self):
     return file(self.filename).read()
 
   def Cleanup(self):
     # TODO(ngeoffray): We run out of space on the build bots for these tests if
     # the temp directories are not removed right after running the test.
     if not self.context.keep_temporary_files:
       self.run_arch.Cleanup()
 
+  def BeforeRunHelper(self, command):

[Siggi Cherem (dart-lang), 2011/11/11 00:06:02]

I'm not sure why this refactoring needed?

[Emily Fortuna, 2011/11/11 00:58:41]

Because I wanted to be able to compile tests, but not copy code. At any rate,
this has gone away because of other changes I made. 

On 2011/11/11 00:06:02, sigmund wrote:

+    """Helper method to merge shared code between StandardTestCase and
+    BrowserTestCase"""
+    if command:
+      # We change the directory where dartc/frog will be launched because
+      # it is not predictable on the location of the compiled file. In
+      # case the test is a web test, we make sure the app file is not
+      # in a subdirectory.
+      cwd = None
+      if self.run_arch.is_web_test: cwd = self.run_arch.temp_dir
+      command = command[:1] + self.context.flags + command[1:]
+      test_output = self.RunCommand(command, cwd=cwd, cleanup=False)
+
+      # If errors were found, fail fast and show compile errors:
+      if test_output.output.exit_code != 0:
+        return test_output
+
+  def BeforeRun(self):
+    """Optionally compile tests."""
+    command = self.run_arch.GetCompileCommand()
+    return self.BeforeRunHelper(command)
+
 
 class MultiTestCase(StandardTestCase):
   """Multiple test cases defined within a single *Test.dart file."""
 
   def __init__(self, context, path, filename, kind, mode, arch, component,
                vm_options = None):
     super(MultiTestCase, self).__init__(context, path, filename, mode, arch,
                                         component, vm_options)
     self.kind = kind
 
@@ skipping 13 matching lines @@
     if self.kind == 'compile-time error':
       return True
     if self.kind == 'runtime error':
       return True
     if self.kind == 'static type error':
       return self.run_arch.HasFatalTypeErrors()
     return False
 
 
 class BrowserTestCase(StandardTestCase):
-  """A test case that executes inside a browser (or DumpRenderTree)."""
+  """A test case that executes inside DumpRenderTree."""
 
   def __init__(self, context, path, filename,
                fatal_static_type_errors, mode, arch, component, vm_options=None):
     super(BrowserTestCase, self).__init__(
         context, path, filename, mode, arch, component, vm_options)
     self.fatal_static_type_errors = fatal_static_type_errors
 
+  def BeforeRun(self):
+    command = self.run_arch.GetCompileCommand(self.fatal_static_type_errors)
+    return self.BeforeRunHelper(command)
+
   def Run(self):
-    """Optionally compiles and then runs the specified test."""
-    command = self.run_arch.GetCompileCommand(self.fatal_static_type_errors)

[Jennifer Messerly, 2011/11/10 23:57:08]

as long as this looks good to Siggi it works for me

-    if command:
-      # We change the directory where dartc will be launched because
-      # it is not predictable on the location of the compiled file. In
-      # case the test is a web test, we make sure the app file is not
-      # in a subdirectory.
-      cwd = None
-      if self.run_arch.is_web_test: cwd = self.run_arch.temp_dir
-      command = command[:1] + self.context.flags + command[1:]
-      test_output = self.RunCommand(command, cwd=cwd, cleanup=False)
-
-      # If errors were found, fail fast and show compile errors:
-      if test_output.output.exit_code != 0:
-        return test_output
-
+    """Runs the specified test, with an update to the exit code to compensate
+    for DumpRenderTree."""
     command = self.run_arch.GetRunCommand()
     test_output = self.RunCommand(command)
     # The return value of DumpRenderedTree does not indicate test failing, but
     # the output does.
     if self.run_arch.HasFailed(test_output.output.stdout):
       test_output.output.exit_code = 1
 
     return test_output
 
 
@@ skipping 30 matching lines @@
             self.filename]
 
     return cmd
 
   def GetName(self):
     return self.path[-1]
 
   def Cleanup(self):
     if not self.context.keep_temporary_files:
       self.run_arch.Cleanup()