Adding in-browser correctness testing via selenium.

tools/testing/architecture.py

 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 #
 
 import os
 import platform
 import re
 import shutil
 import subprocess
@@ skipping 376 matching lines @@
     return path + '.dartium.html'
 
   def GetCompileCommand(self, fatal_static_type_errors=False):
     fatal_static_type_errors = fatal_static_type_errors  # shutup lint!
     return None
 
   def Compile(self):
     return 0
 
 
+class WebDriverArchiecture(ChromiumArchitecture):
+  """Architecture that runs compiled dart->JS (via frog) through a variety of
+  real browsers using WebDriver."""
+
+  def __init__(self, root_path, arch, mode, component, test):
+    super(WebDriverArchiecture, self).__init__(root_path, arch, mode,
+        component, test)
+
+  def GetCompileCommand(self, fatal_static_type_errors=False):
+    """Returns cmdline as an array to invoke the compiler on this test."""
+    # We need an absolute path because the compilation will run
+    # in a temporary directory.
+    frog = os.path.abspath(utils.GetDartRunner(self.mode, self.arch, 'frogsh'))

[ngeoffray, 2011/11/11 09:20:50]

Could that be frog instead? frogsh requires node, and people not working on frog
may not have it. If you turn that into 'frog', you'll get more people able to
test webdriver :)

BTW, that's what I did for leg.

+    build_root = utils.GetBuildRoot(OS_GUESS, self.mode, 'ia32')
+    cmd = [frog, '--libdir=%s' % os.path.abspath(os.path.join(self.root_path, 
+        'frog', 'lib')), '--compile-only',
+        '--out=%s' % self.GetScriptPath()]
+    cmd.append(self.GetTestScriptFile())
+    return cmd
+
+  def GetRunCommand(self, fatal_static_type_errors=False):
+    """Returns a command line to execute for the test."""
+    selenium_location = os.path.join(self.root_path, 'tools', 'testing',
+                                'run_selenium.py')
+    
+    html_output_file = os.path.join(self.GetHtmlPath(), self.GetHtmlName())
+    f = open(html_output_file, 'w')
+    f.write(self.GetHtmlContents())
+    f.close()
+    return [selenium_location, html_output_file]
+
+
 class StandaloneArchitecture(Architecture):
   """Base class for architectures that run tests without a browser."""
 
   def __init__(self, root_path, arch, mode, component, test):
     super(StandaloneArchitecture, self).__init__(root_path, arch, mode, component,
                                                  test)
 
   def GetExecutable(self):
     """Returns the path to the Dart test runner (executes the .dart file)."""
     return utils.GetDartRunner(self.mode, self.arch, self.component)
@@ skipping 83 matching lines @@
 
 
 def GetArchitecture(arch, mode, component, test):
   root_path = os.path.abspath(os.path.join(os.path.dirname(sys.argv[0]), '..'))
   if component == 'chromium':
     return ChromiumArchitecture(root_path, arch, mode, component, test)
 
   elif component == 'dartium':
     return DartiumArchitecture(root_path, arch, mode, component, test)
 
+  elif component == 'webdriver':
+    return WebDriverArchiecture(root_path, arch, mode, component, test)
+
   elif component in ['vm', 'frog', 'frogsh']:
     return StandaloneArchitecture(root_path, arch, mode, component, test)
 
   elif component == 'leg':
     return LegArchitecture(root_path, arch, mode, component, test)
 
   elif component == 'dartc':
     return DartcArchitecture(root_path, arch, mode, component, test)