chrome/browser/ui/dialog_style.cc - Issue 8469006: Promote bubble_window_style to more general dialog_style.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/dialog_style.cc

Issue 8469006: Promote bubble_window_style to more general dialog_style. (Closed) Base URL: /usr/local/google/home/bshe/NoTouchChromium/../TouchChromium/src/@trunk

Patch Set: Add comments. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/chromeos/frame/bubble_window_style.h"	5 #include "chrome/browser/ui/dialog_style.h"

6

7 namespace chromeos {

8	6

9 // static	7 // static

10 const SkColor kBubbleWindowBackgroundColor = SK_ColorWHITE;	8 const SkColor kBubbleWindowBackgroundColor = SK_ColorWHITE;
	flackr 2011/11/10 21:06:46 This is specific to BubbleWindow, can you put this This is specific to BubbleWindow, can you put this constant in bubble_window.cc and remove this file? bshe 2011/11/14 18:58:04 There are more than one place using this backgroun There are more than one place using this background color. I tried to put it in the bubble_window.h file, but we need to delete bubble_window.cc file eventually. It is hard to initialize the background color without bubble_window.cc files. So I put this style back to bubble_window_style.h/cc file. Not sure if there is any better way to do it. On 2011/11/10 21:06:46, flackr wrote: Show quoted text > This is specific to BubbleWindow, can you put this constant in bubble_window.cc > and remove this file? Done.
11

12 } // namespace chromeos

OLD	NEW