Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: content/browser/debugger/devtools_manager_unittest.cc

Issue 8468033: Fix DevToolsManagerTest.ReattachOnCancelPendingNavigation assert failure in debug mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/debugger/devtools_manager_unittest.cc
diff --git a/content/browser/debugger/devtools_manager_unittest.cc b/content/browser/debugger/devtools_manager_unittest.cc
index 5fdc945296d97916a71a4d08fa81b198d1265afd..a2b3bf0f556c7d674d761d52193b93ce9f481d96 100644
--- a/content/browser/debugger/devtools_manager_unittest.cc
+++ b/content/browser/debugger/devtools_manager_unittest.cc
@@ -208,13 +208,13 @@ TEST_F(DevToolsManagerTest, NoUnresponsiveDialogInInspectedTab) {
TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {
contents()->transition_cross_site = true;
- TestRenderViewHost* orig_rvh = rvh();
// Navigate to URL. First URL should use first RenderViewHost.
const GURL url("http://www.google.com");
controller().LoadURL(
url, GURL(), content::PAGE_TRANSITION_TYPED, std::string());
ViewHostMsg_FrameNavigate_Params params1;
InitNavigateParams(&params1, 1, url, content::PAGE_TRANSITION_TYPED);
+ TestRenderViewHost* orig_rvh = rvh();
contents()->TestDidNavigate(orig_rvh, params1);
EXPECT_FALSE(contents()->cross_navigation_pending());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698