Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2992)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 8468032: Fix next_page_id_ in a NTP forced to share an existing WebUI process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Switch to UpdateAndSendMaxPageID Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/site_instance.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index a47ea0cabcb928515ae5a1c599a926e35c2ab0b3..0d62110a08dea762cbf3a6bc8e8586f0fa334c36 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -671,8 +671,10 @@ bool RenderThreadImpl::OnControlMessageReceived(const IPC::Message& msg) {
}
void RenderThreadImpl::OnSetNextPageID(int32 next_page_id) {
- // This should only be called at process initialization time, so we shouldn't
- // have to worry about thread-safety.
+ // This is called at process initialization time or when this process is
+ // being re-used for a new RenderView. It is ok if another RenderView
+ // has identical page_ids or inflates next_page_id_ just before this arrives,
+ // as long as we ensure next_page_id_ is at least this large.
RenderViewImpl::SetNextPageID(next_page_id);
}
« no previous file with comments | « content/browser/site_instance.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698