Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8468021: Add OVERRIDE to ui/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fixes n stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -49 lines) Patch
M ui/base/animation/animation.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ui/base/animation/linear_animation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/animation/multi_animation.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/animation/slide_animation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/animation/throb_animation.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/base/test/ui_cocoa_test_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/native_theme_base.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/platform_font_mac.h View 1 2 chunks +11 lines, -10 lines 0 comments Download
M ui/gfx/platform_font_pango.h View 1 2 chunks +11 lines, -10 lines 0 comments Download
M ui/gfx/platform_font_win.h View 1 2 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
You're an owner. Just adding OVERRIDE everywhere.
9 years, 1 month ago (2011-11-15 22:05:27 UTC) #1
sky
LGTM
9 years, 1 month ago (2011-11-15 22:07:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/8468021/1
9 years, 1 month ago (2011-11-15 22:16:26 UTC) #3
commit-bot: I haz the power
Try job failure for 8468021-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-15 22:37:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/8468021/4002
9 years, 1 month ago (2011-11-15 22:41:52 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 23:42:52 UTC) #6 
Change committed as 110209

Powered by Google App Engine
This is Rietveld 408576698