chrome/browser/safe_browsing/download_protection_service.cc - Issue 8468020: Propagate the SafeBrowsing download protection verdict to the DownloadItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 8468020: Propagate the SafeBrowsing download protection verdict to the DownloadItem. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Add danger state to the download extension API. I couldn't find any static docs for that API. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service.h ('k') | chrome/common/extensions/api/extension_api.json » ('j') | content/browser/download/download_item.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc

index 897d401e144041be6c7026cf2fdc1c6e860988b6..95dfeb55d76d9749bfc8c72dc419f6ec36c1e521 100644

--- a/chrome/browser/safe_browsing/download_protection_service.cc

+++ b/chrome/browser/safe_browsing/download_protection_service.cc

@@ -573,6 +573,8 @@ class DownloadProtectionService::CheckClientDownloadRequest

}

void RecordImprovedProtectionStats(DownloadCheckResultReason reason) {

+ VLOG(2) << "SafeBrowsing download verdict for: "

+ << info_.DebugString() << " verdict:" << reason;

UMA_HISTOGRAM_ENUMERATION("SBClientDownload.CheckDownloadStats",

reason,

REASON_MAX);

@@ -638,6 +640,11 @@ void DownloadProtectionService::CheckDownloadUrl(

base::Bind(&DownloadUrlSBClient::StartCheck, client));

}

+bool DownloadProtectionService::IsSupportedFileType(

+ const FilePath& filename) const {

+ return IsBinaryFile(filename);

void DownloadProtectionService::CancelPendingRequests() {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

for (std::set<scoped_refptr<CheckClientDownloadRequest> >::iterator it =