chrome/browser/download/download_extension_api.cc - Issue 8468020: Propagate the SafeBrowsing download protection verdict to the DownloadItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_extension_api.cc

Issue 8468020: Propagate the SafeBrowsing download protection verdict to the DownloadItem. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Add danger state to the download extension API. I couldn't find any static docs for that API. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/chrome_download_manager_delegate.cc ('k') | chrome/browser/download/download_manager_unittest.cc » ('j') | content/browser/download/download_item.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_extension_api.cc

diff --git a/chrome/browser/download/download_extension_api.cc b/chrome/browser/download/download_extension_api.cc

index dda5e78c0727505d96b6616c7e96994813457365..fab816cd6a39919d82cc2bfa5c6cceb878a57f21 100644

--- a/chrome/browser/download/download_extension_api.cc

+++ b/chrome/browser/download/download_extension_api.cc

@@ -57,6 +57,7 @@ const char kDangerFile[] = "file";

const char kDangerKey[] = "danger";

const char kDangerSafe[] = "safe";

const char kDangerUrl[] = "url";

+const char kDangerContent[] = "content";

const char kEndTimeKey[] = "endTime";

const char kErrorKey[] = "error";

const char kFileSizeKey[] = "fileSize";

@@ -82,6 +83,7 @@ const char* DangerString(DownloadItem::DangerType danger) {

case DownloadItem::NOT_DANGEROUS: return kDangerSafe;

case DownloadItem::DANGEROUS_FILE: return kDangerFile;

case DownloadItem::DANGEROUS_URL: return kDangerUrl;

+ case DownloadItem::DANGEROUS_CONTENT: return kDangerContent;

default:

NOTREACHED();

return "";