chrome/browser/download/download_item_unittest.cc - Issue 8468020: Propagate the SafeBrowsing download protection verdict to the DownloadItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_item_unittest.cc

Issue 8468020: Propagate the SafeBrowsing download protection verdict to the DownloadItem. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Merge Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_extension_api.cc ('k') | chrome/browser/download/download_manager_unittest.cc » ('j') | chrome/common/extensions/api/extension_api.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_item_unittest.cc

diff --git a/chrome/browser/download/download_item_unittest.cc b/chrome/browser/download/download_item_unittest.cc

index 85edae9c42a7d7f08a555eaef4b632ca01454405..1a0a4f0b793f10d8b7415379c5d3d532a932bb90 100644

--- a/chrome/browser/download/download_item_unittest.cc

+++ b/chrome/browser/download/download_item_unittest.cc

@@ -192,8 +192,7 @@ TEST_F(DownloadItemTest, NotificationAfterSetFileCheckResults) {

MockObserver safe_observer(safe_item);

DownloadStateInfo state = safe_item->state_info();;

- state.is_dangerous_file = false;

- state.is_dangerous_url = false;

+ state.danger = DownloadStateInfo::NOT_DANGEROUS;

safe_item->SetFileCheckResults(state);

ASSERT_FALSE(safe_observer.CheckUpdated());

@@ -202,8 +201,7 @@ TEST_F(DownloadItemTest, NotificationAfterSetFileCheckResults) {

MockObserver unsafeurl_observer(unsafeurl_item);

state = unsafeurl_item->state_info();;

- state.is_dangerous_file = false;

- state.is_dangerous_url = true;

+ state.danger = DownloadStateInfo::DANGEROUS_URL;

unsafeurl_item->SetFileCheckResults(state);

ASSERT_TRUE(unsafeurl_observer.CheckUpdated());

@@ -214,8 +212,7 @@ TEST_F(DownloadItemTest, NotificationAfterSetFileCheckResults) {

MockObserver unsafefile_observer(unsafefile_item);

state = unsafefile_item->state_info();;

- state.is_dangerous_file = true;

- state.is_dangerous_url = false;

+ state.danger = DownloadStateInfo::DANGEROUS_FILE;

unsafefile_item->SetFileCheckResults(state);

ASSERT_TRUE(unsafefile_observer.CheckUpdated());