Propagate the SafeBrowsing download protection verdict to the DownloadItem.

chrome/browser/download/download_extension_api.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_extension_api.h"
 
 #include <algorithm>
 #include <cctype>
 #include <iterator>
 #include <set>
@@ skipping 39 matching lines @@
 const char kInvalidURL[] = "Invalid URL";
 
 // Parameter keys
 const char kBodyKey[] = "body";
 const char kBytesReceivedKey[] = "bytesReceived";
 const char kDangerAcceptedKey[] = "dangerAccepted";
 const char kDangerFile[] = "file";
 const char kDangerKey[] = "danger";
 const char kDangerSafe[] = "safe";
 const char kDangerUrl[] = "url";
+const char kDangerContent[] = "content";

[asanka, 2011/11/16 18:34:05]

Nit: These should be ordered alphabetically.

[noelutz, 2011/11/16 23:15:07]

Done.

 const char kEndTimeKey[] = "endTime";
 const char kErrorKey[] = "error";
 const char kFileSizeKey[] = "fileSize";
 const char kFilenameKey[] = "filename";
 const char kHeaderNameKey[] = "name";
 const char kHeaderValueKey[] = "value";
 const char kHeadersKey[] = "headers";
 const char kIdKey[] = "id";
 const char kMethodKey[] = "method";
 const char kMimeKey[] = "mime";
 const char kPausedKey[] = "paused";
 const char kSaveAsKey[] = "saveAs";
 const char kStartTimeKey[] = "startTime";
 const char kStateComplete[] = "complete";
 const char kStateInProgress[] = "in_progress";
 const char kStateInterrupted[] = "interrupted";
 const char kStateKey[] = "state";
 const char kTotalBytesKey[] = "totalBytes";
 const char kUrlKey[] = "url";
 
 const char* DangerString(DownloadItem::DangerType danger) {
   switch (danger) {
     case DownloadItem::NOT_DANGEROUS: return kDangerSafe;
     case DownloadItem::DANGEROUS_FILE: return kDangerFile;
     case DownloadItem::DANGEROUS_URL: return kDangerUrl;
+    case DownloadItem::DANGEROUS_CONTENT: return kDangerContent;

[Randy Smith (Not in Mondays), 2011/11/16 18:04:04]

I think (Asanka?) that we also want to export the "quarantine" info up here,
since that might conceivably have UI effects.  More specifically, I think we
want to export the MAYBE_DANGEROUS_CONTENT enum (if we go that way) so that the
UI knows it might in the future have to show a dangerous download warning for
this item.  This isn't high priority as I don't have a use case, but given that
one of the goals of the extension system is to support everything an alternative
UI might want to have, it seems worth making this visible.

[asanka, 2011/11/16 18:34:05]

I can see how it could be useful.  However I'm not quite certain whether we want
to commit to making it a reliable signal.

[noelutz, 2011/11/16 23:15:07]

Propagated the maybe.

     default:
       NOTREACHED();
       return "";
   }
 }
 
 const char* StateString(DownloadItem::DownloadState state) {
   switch (state) {
     case DownloadItem::IN_PROGRESS: return kStateInProgress;
     case DownloadItem::COMPLETE: return kStateComplete;
@@ skipping 447 matching lines @@
   ListValue args;
   args.Append(arg);
   std::string json_args;
   base::JSONWriter::Write(&args, false, &json_args);
   profile_->GetExtensionEventRouter()->DispatchEventToRenderers(
       event_name,
       json_args,
       profile_,
       GURL());
 }