src/profile-generator.cc - Issue 8468016: Really fix missing HandleScope to prevent local handles to DOMWindow leaking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profile-generator.cc

Issue 8468016: Really fix missing HandleScope to prevent local handles to DOMWindow leaking. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Test added Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/profile-generator.cc

diff --git a/src/profile-generator.cc b/src/profile-generator.cc

index 0284b98d72a5016e17c5a356cfe43ad095459de7..5626acaba4bf7fc37c75921767c12c77a0cff172 100644

--- a/src/profile-generator.cc

+++ b/src/profile-generator.cc

@@ -2470,10 +2470,10 @@ class GlobalObjectsEnumerator : public ObjectVisitor {

// Modifies heap. Must not be run during heap traversal.

void V8HeapExplorer::TagGlobalObjects() {

+ HandleScope scope;

Isolate* isolate = Isolate::Current();

GlobalObjectsEnumerator enumerator;

isolate->global_handles()->IterateAllRoots(&enumerator);

- HandleScope scope;

Handle<String> document_string =

isolate->factory()->NewStringFromAscii(CStrVector("document"));

Handle<String> url_string =

« no previous file with comments | « no previous file | test/cctest/test-heap-profiler.cc » ('j') | test/cctest/test-heap-profiler.cc » ('J')