Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: src/profile-generator.cc

Issue 8468016: Really fix missing HandleScope to prevent local handles to DOMWindow leaking. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.cc
diff --git a/src/profile-generator.cc b/src/profile-generator.cc
index 0284b98d72a5016e17c5a356cfe43ad095459de7..5626acaba4bf7fc37c75921767c12c77a0cff172 100644
--- a/src/profile-generator.cc
+++ b/src/profile-generator.cc
@@ -2470,10 +2470,10 @@ class GlobalObjectsEnumerator : public ObjectVisitor {
// Modifies heap. Must not be run during heap traversal.
void V8HeapExplorer::TagGlobalObjects() {
+ HandleScope scope;
Isolate* isolate = Isolate::Current();
GlobalObjectsEnumerator enumerator;
isolate->global_handles()->IterateAllRoots(&enumerator);
Vitaly Repeshko 2011/11/15 20:06:01 I'm a bit worried that by allocating handles we're
Vitaly Repeshko 2011/11/15 20:07:19 Ah, never mind. We only traverse global handles he
mnaganov (inactive) 2011/11/17 17:46:55 Added a test.
- HandleScope scope;
Handle<String> document_string =
isolate->factory()->NewStringFromAscii(CStrVector("document"));
Handle<String> url_string =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698